[webkit-reviews] review requested: [Bug 29972] Allow JavaScript to manipulate parts of the URL in href attribute. : [Attachment 40586] Patch

[bugzilla-daemon at webkit.org]

Yael <yael.aharon at nokia.com> has asked	for review:
Bug 29972: Allow JavaScript to manipulate parts of the URL in href attribute.
https://bugs.webkit.org/show_bug.cgi?id=29972

Attachment 40586: Patch
https://bugs.webkit.org/attachment.cgi?id=40586&action=review

------- Additional Comments from Yael <yael.aharon at nokia.com>
This patch adds support for manipulating parts of the URL in href. 
Processing as described in
http://dev.w3.org/html5/spec/infrastructure.html#url-decomposition-idl-attribut
es.

The test resuls are almost always the same as FireFox, with some exceptions:
1. FireFox does not allow setting a NULL port, but this should be allowed.
2. FireFox allows setting a null protocol, but this should not be allowed.
3. Encoding of parts of the URL is not always done correctly. I'd like to fix
that as a separate bug, otherwise, this patch will grow very big.

Sorry for omitting the dumpAsText() in the previous test case, it's been
corrected now.