[webkit-reviews] review denied: [Bug 29891] Web Inspector: Introduce inspected object groups for console and watch evaluation results so that they could be released explicitly. : [Attachment 40318] patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at hatcher.name> has denied Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 29891: Web Inspector: Introduce inspected object groups for console and
watch evaluation results so that they could be released explicitly.
https://bugs.webkit.org/show_bug.cgi?id=29891

Attachment 40318: patch
https://bugs.webkit.org/attachment.cgi?id=40318&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>

> +    for (Vector<String>::iterator it = groupIt->second.begin(); it !=
groupIt->second.end(); ++it) {
> +	   m_idToWrappedObject.remove(*it);
> +    }

No need for braces here. Does find really return all objects found? I thought
it just found the first and returned an iterator for that location for fast
removal. I think this code will remove the found object and everything after
it.

But I might be wrong. r- for now.