[webkit-reviews] review denied: [Bug 31868] Web Inspector: Load InspectorResource mime type from CachedResource for 304 response : [Attachment 43843] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 25 07:34:18 PST 2009


Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 31868: Web Inspector: Load InspectorResource mime type from CachedResource
for 304 response
https://bugs.webkit.org/show_bug.cgi?id=31868

Attachment 43843: patch
https://bugs.webkit.org/attachment.cgi?id=43843&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
> +    if (response.httpStatusCode() == 304) {
> +	   CachedResource* cachedResource =
cache()->resourceForURL(response.url().string());
> +	   if (cachedResource)
> +	       m_mimeType = cachedResource->response().mimeType();
> +    }

Could you do this only in case network stack did not provide this information
&& 304?


More information about the webkit-reviews mailing list