[webkit-reviews] review granted: [Bug 31872] centralize required argument parsing in Command : [Attachment 43842] Centralize required argument parsing
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Nov 25 07:32:47 PST 2009
Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 31872: centralize required argument parsing in Command
https://bugs.webkit.org/show_bug.cgi?id=31872
Attachment 43842: Centralize required argument parsing
https://bugs.webkit.org/attachment.cgi?id=43842&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
me: self.assertRaises(Exception, Command._parse_required_arguments, "[ARG1
ARG2]")
i guess that's ok
eric: I can make it smarter to handle that sort of thing
but for now I wanted to document that we didn't expect that to work
me: yeah, probably should add a comment that we might want to accept that case
in the future
More information about the webkit-reviews
mailing list