[webkit-reviews] review requested: [Bug 18282] WebKit crashes with deeply nested divs : [Attachment 43803] Patch providing an optional maximum depth cap to the DOM tree, enabled using --enable-domtree-maxdepth

[bugzilla-daemon at webkit.org]

Keith Kyzivat <kkyzivat at ovi.com> has asked  for review:
Bug 18282: WebKit crashes with deeply nested divs
https://bugs.webkit.org/show_bug.cgi?id=18282

Attachment 43803: Patch providing an optional maximum depth cap to the DOM
tree, enabled using --enable-domtree-maxdepth
https://bugs.webkit.org/attachment.cgi?id=43803&action=review

------- Additional Comments from Keith Kyzivat <kkyzivat at ovi.com>
Attached is the patch I have created to cap the DOM tree when a node is added
(from HTML parse), or appended to (Javascript).
This functionality does not add any memory overhead, however it does add
performance overhead.
Because of this, I have made this an optional feature that must be turned on
using --enable-domtree-maxdepth.
To configure the maximum depth, one changes the MAX_DOM_TREE_DEPTH define in
WebCore/config.h

To more quickly test this on desktop browsers, one should spawn a subshell, and
run ulimit -s 256 (under Linux, under Mac it may be different) before testing
one of the above HTML attachments that reproduce the bug.