[webkit-reviews] review requested: [Bug 30989] [Gtk, WML] Assert failure in http://wap.google.com/wml : [Attachment 43512] Patch with comments incorporated.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 19 10:10:06 PST 2009


Nayan <nayankk at gmail.com> has asked  for review:
Bug 30989: [Gtk, WML] Assert failure in http://wap.google.com/wml
https://bugs.webkit.org/show_bug.cgi?id=30989

Attachment 43512: Patch with comments incorporated.
https://bugs.webkit.org/attachment.cgi?id=43512&action=review

------- Additional Comments from Nayan <nayankk at gmail.com>
Thanks Niko, Eric, Adam for your comments.

I have removed all tabs and replaced them with spaces (Culprit being my emacs
:)), and attached is the updated patch. Please review and let me know if you
have any further comments.

Also, as mentioned in earlier comments, when I run this newly created layout
test (onenterforward-refresh.html), I get following error message. Please help
me to resolve this error.

FAIL: Timed out waiting for notifyDone to be called


More information about the webkit-reviews mailing list