[webkit-reviews] review denied: [Bug 31580] Rewrite the test fast/parser/comment-in-textarea to use dumpAsText : [Attachment 43486] Rewrite the test fast/parser/comment-in-textarea to use dumpAsText (added comment-in-textarea.js and updated ChangeLog)

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Kinuko Yasuda <kinuko at chromium.org>'s
request for review:
Bug 31580: Rewrite the test fast/parser/comment-in-textarea to use dumpAsText
https://bugs.webkit.org/show_bug.cgi?id=31580

Attachment 43486: Rewrite the test fast/parser/comment-in-textarea to use
dumpAsText (added comment-in-textarea.js and updated ChangeLog)
https://bugs.webkit.org/attachment.cgi?id=43486&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
This no longer tests the original bug. That bug had to do with the HTML parser
when in textarea mode, but I don't think setting the innerHTML of a textarea is
sufficient. Instead I think you need to set innerHTML of some other element and
include a <textarea> element in the markup.

That's the danger of rewriting a test. One of the things about the original
test is that it was run before the bug was fixed, and so we know it fails if
the bug exists. But to do that now you'd have to find a way to roll out the
original fix and reintroduce the bug to double check that it still tests the
bug.

I think you'd be OK if you created some other kind of element and used
innerHTML with markup that includes the "<textarea>" and "</textarea>", not
just the comment.