[webkit-reviews] review requested: [Bug 31583] [Qt] better test coverage for ErrorPageExtension : [Attachment 43359] patch 0.2

[bugzilla-daemon at webkit.org]

Antonio Gomes (tonikitoo) <tonikitoo at webkit.org> has asked  for review:
Bug 31583: [Qt] better test coverage for ErrorPageExtension
https://bugs.webkit.org/show_bug.cgi?id=31583

Attachment 43359: patch 0.2
https://bugs.webkit.org/attachment.cgi?id=43359&action=review

------- Additional Comments from Antonio Gomes (tonikitoo)
<tonikitoo at webkit.org>
thx for reviewing.


> +	   (tst_QWebPage::errorPageExtension_withIFrames):
> +	   (tst_QWebPage::errorPageExtension_withFrameset):
> Strange function naming

fixed. 

>  void tst_QWebPage::infiniteLoopJS()
>  {
> +    return;
> Doesn't seem right

typo, removed.

> -    page->mainFrame()->load(QUrl("qrc:///frametest/index.html"));
> +    m_view->setUrl(QUrl("data:text/html,foo"));
> +    QTest::qWait(2000);
> Can these waits be avoided?

removed.