[webkit-reviews] review denied: [Bug 31401] [Qt] inputMethodState incorrect after autocompletion popup : [Attachment 43358] proposed fix for FrameLoaderClientQt.cpp

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Janne Koskinen
<koshuin at gmail.com>'s request for review:
Bug 31401: [Qt] inputMethodState incorrect after autocompletion popup
https://bugs.webkit.org/show_bug.cgi?id=31401

Attachment 43358: proposed fix for FrameLoaderClientQt.cpp
https://bugs.webkit.org/attachment.cgi?id=43358&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
Still no tests, nor explaination why it is not testable.

> @@ -57,6 +57,7 @@
>  #include "ScriptString.h"
>  #include "Settings.h"
>  #include "QWebPageClient.h"
> +#include "EditorClient.h"

Did you run check-webkit-style. These should be ordered.

> +    if (m_frame) {
> +	   if (m_frame->editor() && m_frame->editor()->client())
> +	       m_frame->editor()->client()->setInputMethodState(false);
> +
> +	   // send a mousemove event to
> +	   // (1) update the cursor to change according to whatever is
underneath the mouse cursor right now
> +	   // (2) display the tool tip if the mouse hovers a node which has a
tool tip
> +	   if (m_frame->eventHandler() && m_webFrame->page()) {
> +	       QWidget* view = m_webFrame->page()->view();

So this is a fix for QWebView only and not for QGraphicsWebView. Is a similar
fix needed, if so, why not fix it right away?