[webkit-reviews] review denied: [Bug 31448] Menu button shows wrong content in Chromium : [Attachment 43116] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 16 10:28:56 PST 2009


Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Evan Stade
<estade at chromium.org>'s request for review:
Bug 31448: Menu button shows wrong content in Chromium
https://bugs.webkit.org/show_bug.cgi?id=31448

Attachment 43116: patch
https://bugs.webkit.org/attachment.cgi?id=43116&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: WebKit/chromium/src/WebViewImpl.cpp

> +    } else if (focusedNode) {
> +	   location = focusedNode->getRect().bottomLeft();
> +    } else {

nit: no brackets around single line statements.

otherwise, LGTM


More information about the webkit-reviews mailing list