[webkit-reviews] review granted: [Bug 31479] Make websocket tests work on Windows : [Attachment 43264] Disable wss until all platforms support pyOpenSSL

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 16 10:10:18 PST 2009


Alexey Proskuryakov <ap at webkit.org> has granted Yuzo Fujishima
<yuzo at google.com>'s request for review:
Bug 31479: Make websocket tests work on Windows
https://bugs.webkit.org/show_bug.cgi?id=31479

Attachment 43264: Disable wss until all platforms support pyOpenSSL
https://bugs.webkit.org/attachment.cgi?id=43264&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
I tested that the patch helps on Mac OS X 10.4 (Tiger). I cannot easily test on
Windows.

We don't usually keep commented out code - if necessary, it can be restored
from Subversion history. Do you have a plan how to enable it soon?

r=me, as we need to get the tests running, but please consider my comment.


More information about the webkit-reviews mailing list