[webkit-reviews] review granted: [Bug 30573] [Qt] Broken back/forward after using ErrorPageExtension to set error page : [Attachment 43249] patch 0.4

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 16 07:15:42 PST 2009


Antti Koivisto <koivisto at iki.fi> has granted Antonio Gomes (tonikitoo)
<tonikitoo at webkit.org>'s request for review:
Bug 30573: [Qt] Broken back/forward after using ErrorPageExtension to set error
page
https://bugs.webkit.org/show_bug.cgi?id=30573

Attachment 43249: patch 0.4
https://bugs.webkit.org/attachment.cgi?id=43249&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
The change looks safe to me. activeDocumentLoader() ==
m_provisionalDocumentLoader here except in this Qt specific case so this
shouldn't affect other platforms either.

r=me.


More information about the webkit-reviews mailing list