[webkit-reviews] review requested: [Bug 31325] [Android] Android port lacks Makefiles : [Attachment 43304] Patch 2 for Bug 31325
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Nov 16 06:34:19 PST 2009
Steve Block <steveblock at google.com> has asked for review:
Bug 31325: [Android] Android port lacks Makefiles
https://bugs.webkit.org/show_bug.cgi?id=31325
Attachment 43304: Patch 2 for Bug 31325
https://bugs.webkit.org/attachment.cgi?id=43304&action=review
------- Additional Comments from Steve Block <steveblock at google.com>
> There seems to be a lot of duplication between the *jsc.mk and *.v8.mk files.
> That should really be avoided since we really don't want to have to update
both
> when adding new files. The copyright date also seems out of date.
Fixed
> The "we" is unclear here. You should probably use a more descriptive term
like
> "Android".
Fixed
More information about the webkit-reviews
mailing list