[webkit-reviews] review granted: [Bug 31516] Need to implement ARIA role="directory" : [Attachment 43239] patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 31516: Need to implement ARIA role="directory"
https://bugs.webkit.org/show_bug.cgi?id=31516

Attachment 43239: patch
https://bugs.webkit.org/attachment.cgi?id=43239&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +	   * accessibility/AccessibilityObject.h:
> +	   (WebCore::):

> +	   * accessibility/mac/AccessibilityObjectWrapper.mm:
> +	   (RoleEntry::):

These change log entries are wrong. If the script makes a bad entry like this
you should just delete it before posting the patch.

I should fix prepare-ChangeLog so it never does that. A function name can never
just end in "::" so I can work around the bug pretty easily.

>      TabPanelRole,
>      TreeRole,
>      TreeItemRole,
> +    DirectoryRole,

Can we keep these in alphabetical order?

> -	   return UI_STRING("tab panel", "An ARIA accessibility group that
contenst the content of a tab.");
> +	   return UI_STRING("tab panel", "An ARIA accessibility group that
contains the content of a tab.");

You need to regenerate the strings file after making a change like this one.