[webkit-reviews] review denied: [Bug 31186] Cleanup: Rename fields RenderTextControl::m_edited and RenderTextControl::m_userEdited : [Attachment 43256] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 31186: Cleanup: Rename fields RenderTextControl::m_edited and
RenderTextControl::m_userEdited
https://bugs.webkit.org/show_bug.cgi?id=31186

Attachment 43256: Patch
https://bugs.webkit.org/attachment.cgi?id=43256&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Changing the name of the function in DOMPrivate.idl will break compilation of
Safari for Windows, although it doesn't break the compilation of WebKit itself.


I suggest you take the same approach with Windows that you did with Mac OS X.
Leave the interface of WebKit for clients outside WebKit with the old name.
Change only the names internal to WebKit. So the DOMPrivate.idl name would need
to stay the same, as would DOMHTMLClasses.h, and the function names in
DOMHTMLClasses.cpp.