[webkit-reviews] review requested: [Bug 31183] [Qt] flash plugin doesn't work when using QGraphicsWebView. : [Attachment 43251] Implement plugin rendering

[bugzilla-daemon at webkit.org]

Girish Ramakrishnan <girish at forwardbias.in> has asked  for review:
Bug 31183: [Qt] flash plugin doesn't work when using QGraphicsWebView.
https://bugs.webkit.org/show_bug.cgi?id=31183

Attachment 43251: Implement plugin rendering
https://bugs.webkit.org/attachment.cgi?id=43251&action=review

------- Additional Comments from Girish Ramakrishnan <girish at forwardbias.in>
Here's my take. I was working on this simultaneously for a customer, I have
merged my patch and  Yongjun Zhang's patch.

The idea is that when we don't have a QWebView as the pluginParent, we set the
platformPluginWidget to 0. IOW, have a null platformPluginWidget() indicates to
the code that we have to draw to a pixmap. I also prefer that plugins draw
directly to the view's contextref when we have a native handle available.

A really ugly hack I had to do was to create a fake window to please Flash.
Chrome does this too -
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/plugins/webplugin_d
elegate_impl_mac.mm?view=markup&pathrev=25433 (grep for fake).

What's missing: mouse and (keyboard? - i can test this only after i can give it
focus :D) events don't work, printing doesn't work.

Can someone explain to me how mouse events are sent? Am I reading it right that
we send the global pos(!). If so, having to make it work with QGraphicsView
presents quite a challenge.