[webkit-reviews] review requested: [Bug 30573] [Qt] Broken back/forward after using ErrorPageExtension to set error page : [Attachment 43249] patch 0.4

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Nov 15 09:03:25 PST 2009


Antonio Gomes (tonikitoo) <tonikitoo at webkit.org> has asked  for review:
Bug 30573: [Qt] Broken back/forward after using ErrorPageExtension to set error
page
https://bugs.webkit.org/show_bug.cgi?id=30573

Attachment 43249: patch 0.4
https://bugs.webkit.org/attachment.cgi?id=43249&action=review

------- Additional Comments from Antonio Gomes (tonikitoo)
<tonikitoo at webkit.org>
(In reply to comment #10)
> (From update of attachment 43232 [details])
> You didn't actually include the test in the patch.

err, sorry about that, @abarth. done.

> Also, once you mark the
> test as Skipped on mac, you don't need to mark it as Skipped in mac-leopard,
> etc.

done.


More information about the webkit-reviews mailing list