[webkit-reviews] review requested: [Bug 31438] Feature Request: Implement non-scaling-stroke : [Attachment 43245] Patch that adds vector-effect property/attribute, changes how the stroke is painted when non-scaling-stroke

[bugzilla-daemon at webkit.org]

Jeff Schiller <codedread at gmail.com> has asked  for review:
Bug 31438: Feature Request: Implement non-scaling-stroke
https://bugs.webkit.org/show_bug.cgi?id=31438

Attachment 43245: Patch that adds vector-effect property/attribute, changes how
the stroke is painted when non-scaling-stroke
https://bugs.webkit.org/attachment.cgi?id=43245&action=review

------- Additional Comments from Jeff Schiller <codedread at gmail.com>
This patch is intentionally missing layout tests as I am not quite sure how to
handle that yet.  If someone could please review the patch and then give me
some help, that would be much appreciated.  

Following is the DumpRenderTree output from running the test case file attached
to this bug:

layer at (0,0) size 800x600
  RenderView at (0,0) size 800x600
layer at (0,0) size 800x600
  RenderSVGRoot {svg} at (92.50,42.50) size 315x165
    RenderSVGContainer {g} at (92.50,42.50) size 115x65
[transform={m=((1.00,0.00)(0.00,1.00)) t=(100.00,50.00)}]
      RenderPath {rect} at (92.50,42.50) size 115x65 [stroke={[type=SOLID]
[color=#FF0000] [stroke width=15.00]}] [data="M0.00,0.00 L100.00,0.00
L100.00,50.00 L0.00,50.00 Z"]
      RenderPath {rect} at (98.12,42.50) size 103.75x65
[transform={m=((0.25,0.00)(0.00,1.00)) t=(0.00,0.00)}] [stroke={[type=SOLID]
[color=#00FF00] [stroke width=15.00]}] [data="M0.00,0.00 L400.00,0.00
L400.00,50.00 L0.00,50.00 Z"]
    RenderSVGContainer {g} at (92.50,142.50) size 115x65
[transform={m=((1.00,0.00)(0.00,1.00)) t=(100.00,150.00)}]
      RenderPath {rect} at (92.50,142.50) size 115x65 [stroke={[type=SOLID]
[color=#FF0000] [stroke width=15.00]}] [data="M0.00,0.00 L100.00,0.00
L100.00,50.00 L0.00,50.00 Z"]
      RenderPath {rect} at (98.12,142.50) size 103.75x65
[transform={m=((0.25,0.00)(0.00,1.00)) t=(0.00,0.00)}] [stroke={[type=SOLID]
[color=#00FF00] [stroke width=15.00]}] [data="M0.00,0.00 L400.00,0.00
L400.00,50.00 L0.00,50.00 Z"]
    RenderSVGContainer {g} at (292.50,42.50) size 115x65
[transform={m=((1.00,0.00)(0.00,1.00)) t=(300.00,50.00)}]
      RenderPath {rect} at (292.50,42.50) size 115x65 [stroke={[type=SOLID]
[color=#FF0000] [stroke width=15.00]}] [data="M0.00,0.00 L100.00,0.00
L100.00,50.00 L0.00,50.00 Z"]
      RenderPath {rect} at (298.12,42.50) size 103.75x65
[transform={m=((0.25,0.00)(0.00,1.00)) t=(0.00,0.00)}] [stroke={[type=SOLID]
[color=#00FF00] [stroke width=15.00]}] [data="M0.00,0.00 L400.00,0.00
L400.00,50.00 L0.00,50.00 Z"]
    RenderSVGContainer {g} at (292.50,142.50) size 115x65
[transform={m=((1.00,0.00)(0.00,1.00)) t=(300.00,150.00)}]
      RenderPath {rect} at (292.50,142.50) size 115x65 [stroke={[type=SOLID]
[color=#FF0000] [stroke width=15.00]}] [data="M0.00,0.00 L100.00,0.00
L100.00,50.00 L0.00,50.00 Z"]
      RenderPath {rect} at (298.12,142.50) size 103.75x65
[transform={m=((0.25,0.00)(0.00,1.00)) t=(0.00,0.00)}] [data="M0.00,0.00
L400.00,0.00 L400.00,50.00 L0.00,50.00 Z"]


As can be seen, the green (lime) paths still show in the DumpRenderTree as how
they are in the DOM (narrow rects with transforms on them), despite the strokes
being painted differently.  

Are there any suggestions on the right way to test this - basically is there a
way to test if any red pixels are present in WebKit's output?  I've heard
someone mention pixel tests, but not sure how those are handled.