[webkit-reviews] review granted: [Bug 31509] [Qt] Implement error pages handling support to DRT. : [Attachment 43231] patch 0.1

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Antonio Gomes
(tonikitoo) <tonikitoo at webkit.org>'s request for review:
Bug 31509: [Qt] Implement error pages handling support to DRT.
https://bugs.webkit.org/show_bug.cgi?id=31509

Attachment 43231: patch 0.1
https://bugs.webkit.org/attachment.cgi?id=43231&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>

> +    QWebPage::ErrorPageExtensionReturn* errorPage =
static_cast<QWebPage::ErrorPageExtensionReturn*>(output);
> +
> +    errorPage->content = QString("data:text/html,<body/>").toUtf8();

Wouldn't it make sense to actually print the error code?