[webkit-reviews] review granted: [Bug 31488] DOMHTMLOptionsCollection is missing some implementation : [Attachment 43199] patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Jon Honeycutt <jhoneycutt at apple.com>'s request for
review:
Bug 31488: DOMHTMLOptionsCollection is missing some implementation
https://bugs.webkit.org/show_bug.cgi?id=31488

Attachment 43199: patch
https://bugs.webkit.org/attachment.cgi?id=43199&action=review

------- Additional Comments from mitz at webkit.org
> +    if (index >= m_collection->length())
> +	   return E_FAIL;
> +
> +    *result = DOMNode::createInstance(m_collection->item(index));
> +    return S_OK;

Can you just let HTMLOptionsCollection::item() return 0 and then null-check the
result instead of bounds-checking index? It would be more like
DOMHTMLCollection::item().

r=me either way