[webkit-reviews] review denied: [Bug 30573] [Qt] Broken back/forward after using ErrorPageExtension to set error page : [Attachment 43232] patch 0.3

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Nov 14 16:02:12 PST 2009


Adam Barth <abarth at webkit.org> has denied Antonio Gomes (tonikitoo)
<tonikitoo at webkit.org>'s request for review:
Bug 30573: [Qt] Broken back/forward after using ErrorPageExtension to set error
page
https://bugs.webkit.org/show_bug.cgi?id=30573

Attachment 43232: patch 0.3
https://bugs.webkit.org/attachment.cgi?id=43232&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
You didn't actually include the test in the patch.  Also, once you mark the
test as Skipped on mac, you don't need to mark it as Skipped in mac-leopard,
etc.


More information about the webkit-reviews mailing list