[webkit-reviews] review granted: [Bug 30960] [CAIRO] shadow support for Canvas and SVG : [Attachment 43167] Update to improve performance, correct security hole.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 13 10:43:06 PST 2009


Alexey Proskuryakov <ap at webkit.org> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 30960: [CAIRO] shadow support for Canvas and SVG
https://bugs.webkit.org/show_bug.cgi?id=30960

Attachment 43167: Update to improve performance, correct security hole.
https://bugs.webkit.org/attachment.cgi?id=43167&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
> +    cairo_get_dash(srcCr, reinterpret_cast<double*>(dashes.data()),
&offset);
> +    cairo_set_dash(dstCr, reinterpret_cast<double*>(dashes.data()),
dashCount, offset);

Please remove the unneeded reinterpret_cast.

r=me


More information about the webkit-reviews mailing list