[webkit-reviews] review requested: [Bug 30173] [Qt] Make it possible to apply the CSS background color to the native painted widgets instead of to the actual element : [Attachment 43169] Proposed patch

[bugzilla-daemon at webkit.org]

Carol Szabo <carol.szabo at nokia.com> has asked  for review:
Bug 30173: [Qt] Make it possible to apply the CSS background color to the
native painted widgets instead of to the actual element
https://bugs.webkit.org/show_bug.cgi?id=30173

Attachment 43169: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=43169&action=review

------- Additional Comments from Carol Szabo <carol.szabo at nokia.com>
This patch implements about 3 different related issues:
1. Rendering of Text input background does not follow the various shapes that
text boxes can have under various Qt styles.
2. The default CSS style sheets do not reflect the default control backgrounds
as set through various QStyles and QStyleSheets.
3. When the user uses CSS to change the background and foreground colors of
controls, these changes are not accurately reflected in control rendering.
Causing weird things such as invisible text instead of reverse video for some
controls such as Search.

My original goal was to just fix the 3rd issue, but after sever rounds of
review and discussion it was determined that all three issues need to be
addressed for the patch to be accepted.