[webkit-reviews] review granted: [Bug 30997] [Gtk] Implement AtkDocument's attribute support : [Attachment 43069] Layout Test - Take 3

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Joanmarie Diggs
<joanmarie.diggs at gmail.com>'s request for review:
Bug 30997: [Gtk] Implement AtkDocument's attribute support
https://bugs.webkit.org/show_bug.cgi?id=30997

Attachment 43069: Layout Test - Take 3
https://bugs.webkit.org/attachment.cgi?id=43069&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
I think it's better to add testing in the same patch that adds the
functionality, usually, since it is important that the new functionality is
tested as soon as possible (meaning when it is committed), so I would recommend
doing it that way for future patches =). Regarding, unit tests are
platform-specific, there is no unit testing structure for webkit as a whole, so
when you want to test anything that is not platform-specific API, Layout Tests
are a better option. Thanks for the patch!