[webkit-reviews] review granted: [Bug 31420] [V8] Table-driven setup for binding template callback functions : [Attachment 43076] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Nov 12 10:51:09 PST 2009
Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Jens Alfke
<snej at chromium.org>'s request for review:
Bug 31420: [V8] Table-driven setup for binding template callback functions
https://bugs.webkit.org/show_bug.cgi?id=31420
Attachment 43076: patch
https://bugs.webkit.org/attachment.cgi?id=43076&action=review
------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
r=me, feel free to commit after this fix-up:
> +v8::Local<v8::Signature>
configureTemplate(v8::Persistent<v8::FunctionTemplate>desc,
> + const char *interfaceName,
> + V8ClassIndex::V8WrapperType
parentClassIndex,
> + int fieldCount,
> + const BatchedAttribute*
attributes,
> + size_t attributeCount,
> + const BatchedCallback* callbacks,
> + size_t callbackCount)
> +{
> + desc->SetClassName(v8::String::New(interfaceName));
> + v8::Local<v8::ObjectTemplate> instance = desc->InstanceTemplate();
> + instance->SetInternalFieldCount(fieldCount);
> + if (parentClassIndex)
> + desc->Inherit(V8DOMWrapper::getTemplate(parentClassIndex));
> + if (attributeCount)
> + batchConfigureAttributes(instance, desc->PrototypeTemplate(),
> + attributes, attributeCount);
> + v8::Local<v8::Signature> default_signature = v8::Signature::New(desc);
Should be defaultSignature in WebKit-land.
More information about the webkit-reviews
mailing list