[webkit-reviews] review requested: [Bug 31411] Web Inspector: breakpoint sidebar entries should allow click over entire list item : [Attachment 43064] proposed patch 2009/11/12 - a

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 12 08:16:50 PST 2009


Patrick Mueller <pmuellr at yahoo.com> has asked  for review:
Bug 31411: Web Inspector: breakpoint sidebar entries should allow click over
entire list item
https://bugs.webkit.org/show_bug.cgi?id=31411

Attachment 43064: proposed patch 2009/11/12 - a
https://bugs.webkit.org/attachment.cgi?id=43064&action=review

------- Additional Comments from Patrick Mueller <pmuellr at yahoo.com>
For a breakpoint list item in the breakpoints sidebar:

- change the label/link, which contained the sourceURL and line number, to just
a text node, and remove the click event
- add a click event to the breakpointElement itself
- change the name of the labelClicked handler to breakpointClicked
- change the checkboxClicked handler to stop propogation, otherwise
breakpointClick will be inadvertently invoked as well


More information about the webkit-reviews mailing list