[webkit-reviews] review granted: [Bug 31228] Windows environment variables should be set automatically : [Attachment 43043] Automatically set the environment variables by editing HKCU\Environment.

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Marwan Al Jubeh
<marwan.aljubeh at gmail.com>'s request for review:
Bug 31228: Windows environment variables should be set automatically
https://bugs.webkit.org/show_bug.cgi?id=31228

Attachment 43043: Automatically set the environment variables by editing
HKCU\Environment.
https://bugs.webkit.org/attachment.cgi?id=43043&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> +	   if ($restartNeeded) {
> +	       print "Please restart your computer before attempting to build
inside Visual Studio.\n\n";
> +	   }

I think logging out and back in would also work. Maybe we should change the
message to say that?

And it sounds like we could skip the isWindowsNT() check entirely (see comment
5).

r=me even if those two things don't get changed. Thanks for fixing this!