[webkit-reviews] review requested: [Bug 31375] Web Inspector: breakpoints in named evals are not restored after a reload : [Attachment 43063] proposed patch 2009/11/12 - a

[bugzilla-daemon at webkit.org]

Patrick Mueller <pmuellr at yahoo.com> has asked  for review:
Bug 31375: Web Inspector: breakpoints in named evals are not restored after a
reload
https://bugs.webkit.org/show_bug.cgi?id=31375

Attachment 43063: proposed patch 2009/11/12 - a
https://bugs.webkit.org/attachment.cgi?id=43063&action=review

------- Additional Comments from Patrick Mueller <pmuellr at yahoo.com>
per previous comment:

- in ScriptsPanel::addScript(), changed to use the calculated sourceURL rather
than the original sourceURL.  The calculated one will have an actual name if
the script was an eval that used the //@sourceURL= annotation comment

- in ScriptsPanel::addScript(), moved the cache-filling of _sourceIDmap[] to
ABOVE the place it's used, later, in a called function, to paint the breakpoint
marker in the source panel; without this fix, everything works, but the
breakpoint markers are not repainted for these breakpoints

- added a new manual test case