[webkit-reviews] review denied: [Bug 31363] fast/css/color-correction tests crash on Windows : [Attachment 42982] Null Checks

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Brian Weinstein
<bweinstein at apple.com>'s request for review:
Bug 31363: fast/css/color-correction tests crash on Windows
https://bugs.webkit.org/show_bug.cgi?id=31363

Attachment 42982: Null Checks
https://bugs.webkit.org/attachment.cgi?id=42982&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
I don’t understand why this is appropriate. Is it really OK to just do the
wrong thing and use the wrong color? Doesn't this break the feature on Windows
and worse, make it use the wrong color in various places?

> -	   CGContextSetStrokeColorSpace(context, sRGBColorSpaceRef());
> +	   if (CGColorSpaceRef sRGBColorSpace = sRGBColorSpaceRef())
> +	       CGContextSetFillColorSpace(context, sRGBColorSpace);

You changed stroke to fill here.

If Windows CG is getting 0 for some of these things we need to figure out why.
Just doing the wrong thing to avoid a crash is not good. In the mean time,
skipping the tests might be the best short term measure.

review- because of the stroke to fill change and also my general disagreement
that this is a fix.