[webkit-reviews] review denied: [Bug 26584] [Qt] Printing extra information : [Attachment 39513] Ariya Hidayat's solution

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 11 12:36:50 PST 2009


Simon Hausmann <hausmann at webkit.org> has denied Jakob Truelsen
<antialize at gmail.com>'s request for review:
Bug 26584: [Qt] Printing extra information
https://bugs.webkit.org/show_bug.cgi?id=26584

Attachment 39513: Ariya Hidayat's solution
https://bugs.webkit.org/attachment.cgi?id=39513&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
This patch has various style issues and it changes the signature of an existing
public method, which breaks binary compatibility with Visual Studio builds.

I think the concept of it is okay, but we indeed have to discuss properly
whether this belongs straight into QWebFrame or into a separate class.


More information about the webkit-reviews mailing list