[webkit-reviews] review denied: [Bug 31217] Optimize code size of V8 DOM bindings : [Attachment 42800] patch 2

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Jens Alfke
<snej at chromium.org>'s request for review:
Bug 31217: Optimize code size of V8 DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=31217

Attachment 42800: patch 2
https://bugs.webkit.org/attachment.cgi?id=42800&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
Ok, this is epic-sized. I see a bunch of smaller patches in it:

1) Converting v8::Undefied to empty -- awesome!
    I would be very careful about this. Returning empty vs. Undefined actually
does matter in cases where the callback an interceptor.
    We even have a helper called notHandledByInterceptor to distinguish that
case.

2) Introducing transferHiddenDependency -- great!

3) Optimizing exception case -- super-duper!

4) Optimizing "Reflect" case -- even better!

5) Deinlining

6) ...

Let's try to break them up into incremental chunks. This way, if something goes
awry, we won't have to revert the whole thing, and we can observe perf/size
changes more granularly.