[webkit-reviews] review granted: [Bug 31337] Add test for Web Socket send : [Attachment 42938] add test for web socket send
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Nov 11 09:38:53 PST 2009
Eric Seidel <eric at webkit.org> has granted Yuzo Fujishima <yuzo at google.com>'s
request for review:
Bug 31337: Add test for Web Socket send
https://bugs.webkit.org/show_bug.cgi?id=31337
Attachment 42938: add test for web socket send
https://bugs.webkit.org/attachment.cgi?id=42938&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
The test itself looks good. Is websocket already added to the skipped list for
platforms which don't have it turned on?
Single line ifs don't need { }
+if (window.layoutTestController) {
+ layoutTestController.waitUntilDone();
+}
+ if (window.layoutTestController) {
+ layoutTestController.notifyDone();
+ }
More information about the webkit-reviews
mailing list