[webkit-reviews] review requested: [Bug 27451] stepUp() and stepDown() support for <input type=number/range> : [Attachment 42926] stepUp() and stepDown() (rev.5)

[bugzilla-daemon at webkit.org]

TAMURA, Kent <tkent at chromium.org> has asked  for review:
Bug 27451: stepUp() and stepDown() support for <input type=number/range>
https://bugs.webkit.org/show_bug.cgi?id=27451

Attachment 42926: stepUp() and stepDown() (rev.5)
https://bugs.webkit.org/attachment.cgi?id=42926&action=review

------- Additional Comments from TAMURA, Kent <tkent at chromium.org>
(In reply to comment #11)
> > Would you take a look at Part 1 and Part 2 patches in this bug please?
> OK, I see now. Confusing!

I moved them to their own bugs.

> That is not what I was talking about. I was talking about using declarations
in
> the header files inside WTF. For example, look at the bottom of ASCIICType.h.


Oh, I have understood.	Updated dtoa.h in the patch part 1.

> > So we don't need to test parameter errors like the following your comment,
> > right?
> 
> We do need to test them. Just because the bindings generator provides the
> support doesn't mean we don't want test cases. We should always test such
> things to make sure we are getting the behavior we need.

I added tests for null/undefined/extra arguments.