[webkit-reviews] review requested: [Bug 31213] The CounterNode class does not support all methods necessary to efficiently update the counter tree as needed per CSS2.1 : [Attachment 42925] Proposed Patch

[bugzilla-daemon at webkit.org]

Carol Szabo <carol.szabo at nokia.com> has asked  for review:
Bug 31213: The CounterNode class does not support all methods necessary to
efficiently update the counter tree as needed per CSS2.1
https://bugs.webkit.org/show_bug.cgi?id=31213

Attachment 42925: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=42925&action=review

------- Additional Comments from Carol Szabo <carol.szabo at nokia.com>
This patch addresses Darin's coding style concerns.
Regarding the code that appears to be a bug fix in RenderObjectChildren.cpp,
the reason why I did not attach a test case for that code is because the code
does not fix any bugs since it is not properly called yet for DOM changes,
where it would be important, the test case that this code contributes to fixing
is part of the fix for 11031 for which this change is a prerequisite. Until
that code is committed, my code only fixes a dangling reference for some test
case, but it has no visible impact.