[webkit-reviews] review denied: [Bug 31291] Web Inspector: Speed up syntax highlighter : [Attachment 42865] proposed patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at hatcher.name> has denied Keishi Hattori
<casey.hattori at gmail.com>'s request for review:
Bug 31291: Web Inspector: Speed up syntax highlighter
https://bugs.webkit.org/show_bug.cgi?id=31291

Attachment 42865: proposed patch
https://bugs.webkit.org/attachment.cgi?id=42865&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
> -		   while (node.firstChild)
> -		       node.removeChild(node.firstChild);

Why isn't this needed in the loop anymore? (I see removeChildren was added
outside the loop.)


> -		   this.lineFragment =null;
> +		   this.newLine =null;

Add a space before null.


> -	   action: identOrKeywordAction,
> -	   dontAppendNonToken: true
> +	   action: identOrKeywordAction

Why this change?

r- for the missing space.