[webkit-reviews] review denied: [Bug 27959] Support for validationMessage : [Attachment 41530] Patch v2b

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 10 09:34:59 PST 2009


Eric Seidel <eric at webkit.org> has denied Michelangelo De Simone
<micdesim at gmail.com>'s request for review:
Bug 27959: Support for validationMessage
https://bugs.webkit.org/show_bug.cgi?id=27959

Attachment 41530: Patch v2b
https://bugs.webkit.org/attachment.cgi?id=41530&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
OK.  So this test shoudl just be Skipped on other platforms instead of disabled
for all.

I agree, I think it's lame that the HTML5 spec exposes localized strings in
this way.  It will be impossible for localizers to know how these strings are
used, and thus impossible for them to end up with the right localizations.

I don't think this should be PLATFORM(MAC) only.  Instead "notImplemented()"
style functions should be added to the other platforms. 

Your localizable.strings patch doesn't look right as ir removes accessiblity
strings.

Otherwise this could be OK.


More information about the webkit-reviews mailing list