[webkit-reviews] review requested: [Bug 25415] [GTK][ATK] Please implement support for get_text_at_offset : [Attachment 42855] Fix for the issue in comment 57

[bugzilla-daemon at webkit.org]

Joanmarie Diggs <joanmarie.diggs at gmail.com> has asked  for review:
Bug 25415: [GTK][ATK] Please implement support for get_text_at_offset
https://bugs.webkit.org/show_bug.cgi?id=25415

Attachment 42855: Fix for the issue in comment 57
https://bugs.webkit.org/attachment.cgi?id=42855&action=review

------- Additional Comments from Joanmarie Diggs <joanmarie.diggs at gmail.com>
It turns out that the segfault occurs in all entries and whether there is text
or not. (At the time I made the comment in question, entries didn't implement
the accessible text interface.)

This patch seems to solve the problem and cause get_text_at_offset to do the
right thing in single-line and multi-line entries.

Note that this patch assumes the patch for comment 59. Not so much in terms of
function as in terms of whether this patch will apply cleanly. :-)

Also note that I think this is the last of the get_text_at_offset-specific
issues. And there was much rejoicing. Yea.