[webkit-reviews] review requested: [Bug 26310] Webkit should generate "compositionstart", "compositionend", and "text" events like firefox : [Attachment 42854] A proposed patch 3 (for WebKit and Chromium)

[bugzilla-daemon at webkit.org]

Hironori Bono <hbono at chromium.org> has asked  for review:
Bug 26310: Webkit should generate "compositionstart", "compositionend", and
"text" events like firefox
https://bugs.webkit.org/show_bug.cgi?id=26310

Attachment 42854: A proposed patch 3 (for WebKit and Chromium)
https://bugs.webkit.org/attachment.cgi?id=42854&action=review

------- Additional Comments from Hironori Bono <hbono at chromium.org>
Thank you for your comments.

> What is the reason for having the code be Mac only? I can't see any mac
specific code in it...

This is just because I haven't had any idea how I can add files to GTK (or QT)
projects.
I have added them and checked this change can be compiled on WebKit GTK and
WebKit Win. (I'm not confident this is correct, though. Please feel free to
blame me if I'm wrong.)

> Your test case should describe how to run the test manually

Thank you for noticing this.
I added a brief comment how to use my layout test manually

Regards,

Hironori Bono