[webkit-reviews] review denied: [Bug 25415] [GTK][ATK] Please implement support for get_text_at_offset : [Attachment 42712] Fix for the issue in comment 41, 55

[bugzilla-daemon at webkit.org]

Xan Lopez <xan.lopez at gmail.com> has denied Joanmarie Diggs
<joanmarie.diggs at gmail.com>'s request for review:
Bug 25415: [GTK][ATK] Please implement support for get_text_at_offset
https://bugs.webkit.org/show_bug.cgi?id=25415

Attachment 42712: Fix for the issue in comment 41, 55
https://bugs.webkit.org/attachment.cgi?id=42712&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
Well, this is the line that makes us advance to the next paragraph boundary. If
you remove it I think this function won't work for text chunks with more than
one of those...? If removing that makes the crash go away I think it's very
likely the problem is some mix-up between lengths in characters and lengths in
bytes. What are the indexs the pango function return specified in? Characters?
If that is so then advancing the string like we do it there is wrong, and we
should use the glib functions for doing so I think.