[webkit-reviews] review denied: [Bug 31238] Web Inspector: Inspector should support copy() in the command line : [Attachment 42713] proposed patch 2

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Keishi Hattori
<casey.hattori at gmail.com>'s request for review:
Bug 31238: Web Inspector: Inspector should support copy() in the command line
https://bugs.webkit.org/show_bug.cgi?id=31238

Attachment 42713: proposed patch 2
https://bugs.webkit.org/attachment.cgi?id=42713&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
What you should do instead is:
- Introduce copyText in InspectorBackend.(idl, h, cpp). Just mimic copyNode
there and pass text instead of node id.
- Implement it as Pasteboard::generalPasteboard()->writePlainText(text); (see
copyNode again)
- Make a simple call to it from your new copy API method.

We could be even more cleaver here and copy markup in case selected object is
node (make an instanceof check under copy and choose between copyText and
copyNode to call). [object HTMLElement] is not too informative otherwise...