[webkit-reviews] review requested: [Bug 30659] Web Inspector: Leftover Breakpoints in the Sidebar Pane : [Attachment 42520] proposed patch 2009/11/04 - a

[bugzilla-daemon at webkit.org]

Patrick Mueller <pmuellr at yahoo.com> has asked  for review:
Bug 30659: Web Inspector: Leftover Breakpoints in the Sidebar Pane
https://bugs.webkit.org/show_bug.cgi?id=30659

Attachment 42520: proposed patch 2009/11/04 - a
https://bugs.webkit.org/attachment.cgi?id=42520&action=review

------- Additional Comments from Patrick Mueller <pmuellr at yahoo.com>
The problem is that the sidebar wasn't being cleaned up - still pointed to the
sourceID of the original script (sourceIDs for script change on reload).

Easiest thing to do is to call ScriptPanel's removeBreakpoint() on the old one,
change the sourceID of the breakpoint to the new sourceID, then call
addBreakpoint().   It's a bit overkill, as I >think< all that really needs to
be done is to change the sidebar's sourceID.  But that's a bit reach-y.  And
untested.

As I mentioned in a previous comment, I think a lot of this breakpoint stuff
can be consolidated somehow; too much function spread over too many files. 
This bug was an example of the problem of the spread.

I need to get reloading of breakpoint's in named eval()'s working (no simple
fix for that).	Thinking a refactoring at that point might be appropriate. 
Patching this one for now would be great because this is a bug a lot of people
will hit.