[webkit-reviews] review granted: [Bug 16062] SVGMatrix multiply method is wrong way around : [Attachment 42507] Updated patch: added check for enough arguments. Also added copyright as this change is now over 10 lines.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Nov 4 13:57:44 PST 2009
Simon Fraser (smfr) <simon.fraser at apple.com> has granted Jeff Schiller
<codedread at gmail.com>'s request for review:
Bug 16062: SVGMatrix multiply method is wrong way around
https://bugs.webkit.org/show_bug.cgi?id=16062
Attachment 42507: Updated patch: added check for enough arguments. Also added
copyright as this change is now over 10 lines.
https://bugs.webkit.org/attachment.cgi?id=42507&action=review
------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
I think this is good, but you might want to consider adding the test to
SVGMatrix-interface.svg rather than creating a new test. Ideally
SVGMatrix-interface.svg would be a much more comprehensive test of the
SVGMatrix interface. See LayoutTests/transforms/cssmatrix-2d-interface.xhtml
which could probably be converted to SVGMatrix easily.
More information about the webkit-reviews
mailing list