[webkit-reviews] review granted: [Bug 30909] 10.6 SDK building for 10.5: GraphicsContextCG.cpp:1056: warning: enumeration value 'kCGInterpolationMedium' not handled in switch : [Attachment 42410] Check MAC_OS_X_VERSION_MAX_ALLOWED and MAC_OS_X_VERSION_MIN_REQUIRED directly

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Mark Mentovai <mark at chromium.org>'s
request for review:
Bug 30909: 10.6 SDK building for 10.5: GraphicsContextCG.cpp:1056: warning:
enumeration value 'kCGInterpolationMedium' not handled in switch
https://bugs.webkit.org/show_bug.cgi?id=30909

Attachment 42410: Check MAC_OS_X_VERSION_MAX_ALLOWED and
MAC_OS_X_VERSION_MIN_REQUIRED directly
https://bugs.webkit.org/attachment.cgi?id=42410&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I'm sorry this simple change has taken so much back-and-forth.	I think this
patch looks good.  Although personally I would prefer the HAVE/USE stuff to be
defined only in the CG file, since it makes little sense for all ports to see
it (Which they do with it in config.h).

+    // Fall through to InterpolationHigh if kCGInterpolationMedium is not
usable
should have a period after a full sentence.

Anyway, LGTM, but I would like to see the defines you added to config.h moved
back to platform/graphics/cg/GraphicsContextCG.cpp instead.  I'll mark r+ and
let you land this manually with modifications.	Mark or Darin can give further
comments/instructions if they disagree with that approach.