[webkit-reviews] review granted: [Bug 31079] (r48167) "Document.h" includes "Page.h", makes WebCore painful to work on : [Attachment 42409] Revert Document.h to a forward declaration of Page, move the inline function into Document.cpp, and add the Page.h include to the few other sites that now need it.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 3 13:04:12 PST 2009


Darin Adler <darin at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 31079: (r48167) "Document.h" includes "Page.h", makes WebCore painful to
work on
https://bugs.webkit.org/show_bug.cgi?id=31079

Attachment 42409: Revert Document.h to a forward declaration of Page, move the
inline function into Document.cpp, and add the Page.h include to the few other
sites that now need it.
https://bugs.webkit.org/attachment.cgi?id=42409&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +InspectorTimelineAgent* Document::inspectorTimelineAgent() const {
> +    return page() ? page()->inspectorTimelineAgent() : 0;
> +}

Please move the brace to a separate line rather than having it on the same line
as the function.

Otherwise, fine, r=me


More information about the webkit-reviews mailing list