[webkit-reviews] review granted: [Bug 13233] Need to implement an optimizing XPath evaluator : [Attachment 30817] Don't needlessly sort location path results

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 13233: Need to implement an optimizing XPath evaluator
https://bugs.webkit.org/show_bug.cgi?id=13233

Attachment 30817: Don't needlessly sort location path results
https://bugs.webkit.org/attachment.cgi?id=30817&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +	       NodeSet(const NodeSet& other) : m_isSorted(other.m_isSorted),
m_subtreesAreDisjoint(other.m_subtreesAreDisjoint), m_nodes(other.m_nodes) { }
> +	       NodeSet& operator=(const NodeSet& other) { m_isSorted =
other.m_isSorted; m_subtreesAreDisjoint = other.m_subtreesAreDisjoint; m_nodes
= other.m_nodes; return *this; }

You should instead delete these explicit definitions. The compiler defaults
would work fine.

r=me