[webkit-reviews] review granted: [Bug 13233] Need to implement an optimizing XPath evaluator : [Attachment 30812] first step

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 13233: Need to implement an optimizing XPath evaluator
https://bugs.webkit.org/show_bug.cgi?id=13233

Attachment 30812: first step
https://bugs.webkit.org/attachment.cgi?id=30812&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +	       void addSubExpression(Expression* expr)
> +	       {
> +		   m_subExpressions.append(expr);
> +		   m_isContextNodeSensitive = m_isContextNodeSensitive ||
expr->m_isContextNodeSensitive;
> +		   m_isContextPositionSensitive = m_isContextPositionSensitive
|| expr->m_isContextPositionSensitive;
> +		   m_isContextSizeSensitive = m_isContextSizeSensitive ||
expr->m_isContextSizeSensitive;
> +	       }

How about using |= here?

r=me