[webkit-reviews] review requested: [Bug 25126] UString should allow its buffer to be shared. : [Attachment 30661] Proposed fix.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 25 19:25:45 PDT 2009

David Levin <levin at chromium.org> has asked  for review:
Bug 25126: UString should allow its buffer to be shared.

Attachment 30661: Proposed fix.

------- Additional Comments from David Levin <levin at chromium.org>
The only changes from the last patch were:
1. Addressing previous given feedback and catching up with recent changes to
2. I switch the conditional around in Rep::baseString which (helped branch
prediction enough to) made the performance equivalent to what it was before on
Sunspider.  So there is no change in Sunspider results (as noted by running it
1000 times with and without the change).

More information about the webkit-reviews mailing list