[webkit-reviews] review denied: [Bug 24758] [Gtk] Implement a WebDataSource for the gtk port : [Attachment 29261] WebKitWebResource implementation

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has denied Maciej Stachowiak
<mjs at apple.com>'s request for review:
Bug 24758: [Gtk] Implement a WebDataSource for the gtk port
https://bugs.webkit.org/show_bug.cgi?id=24758

Attachment 29261: WebKitWebResource implementation
https://bugs.webkit.org/attachment.cgi?id=29261&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
> +				       "url",
> +				       "URL",
> +				       "The url of the resource",
> +				       NULL,
> +				       WEBKIT_PARAM_READABLE));

Missing the i18n calls here.

> +WEBKIT_API G_CONST_RETURN gchar *
> +webkit_web_resource_get_data 	      (WebKitWebResource 
*web_resource);

Hmm. Is it guaranteed that the data will always be null-terminated? Most
probably not, since we'll have WebResources for all kinds of resources, right?
Such as images, for instance? I think we may want to use GString, or something
like:

WEBKIT_API G_CONST_RETURN gchar *
webkit_web_resource_get_data		   (WebKitWebResource  *web_resource,
gsize* length);

 159	     const gchar* data;

Length here.

 160	 };
 161	 WebKitWebResource*
 162	
webkit_web_resource_init_with_core_resource(PassRefPtr<WebCore::ArchiveResource
>);

new_with_core_resource instead of init_with to match history item.

I'd r+ with those changes, let me ping xan so that he can check on the API
along with me =). r- for now, because of those issues.