[webkit-reviews] review denied: [Bug 26010] Serialize calls to WebInspector : [Attachment 30652] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon May 25 10:55:30 PDT 2009
Timothy Hatcher <timothy at hatcher.name> has denied Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 26010: Serialize calls to WebInspector
https://bugs.webkit.org/show_bug.cgi?id=26010
Attachment 30652: patch
https://bugs.webkit.org/attachment.cgi?id=30652&action=review
------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
> + overrideFrontendObject(m_scriptState, webInspectorObj);
I think "proxy" is a better term for this than "override".
Maybe frontendProxyObject?
> +WebInspector.dispatch = function() {
> + var methodName = arguments[0];
> + var parameters = Array.prototype.slice.call(arguments, 1);
> + WebInspector[methodName].apply(this, parameters);
> +}
Please use 4 spaces for indenting.
r- for that. Otherwise r+.
More information about the webkit-reviews
mailing list