[webkit-reviews] review granted: [Bug 25974] [V8] Enable timers in Chromium workers : [Attachment 30602] Proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon May 25 10:30:48 PDT 2009
Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Dmitry Titov
<dimich at chromium.org>'s request for review:
Bug 25974: [V8] Enable timers in Chromium workers
https://bugs.webkit.org/show_bug.cgi?id=25974
Attachment 30602: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=30602&action=review
------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
Fine to land after addressing these style nits.
> + } else {
> + scriptController->evaluate(m_code);
> + }
No braces here?
> + v8::Handle<v8::Value> function = args[0];
> + int32_t timeout = argumentCount >= 2 ? args[1]->Int32Value() : 0;
Weird spacing thing?
More information about the webkit-reviews
mailing list